Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation of a deployment via docker compose #894

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

make-github-pseudonymous-again
Copy link
Contributor

@make-github-pseudonymous-again make-github-pseudonymous-again commented Apr 17, 2024

Fixes #884 and fixes #895.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.46%. Comparing base (9574a14) to head (d0d870e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #894   +/-   ##
=======================================
  Coverage   64.46%   64.46%           
=======================================
  Files         703      703           
  Lines        9705     9705           
  Branches     1335     1335           
=======================================
  Hits         6256     6256           
  Misses       3004     3004           
  Partials      445      445           
Flag Coverage Δ
test 69.76% <ø> (ø)
test-app 53.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is missing `oplog: true` from the existing `mup` configuration I
think.
@make-github-pseudonymous-again
Copy link
Contributor Author

Waiting on a solution for ArcticLampyrid/action-wait-for-workflow#171. Otherwise, will have to find another solution to wait for image to be ready. #900 is a potential solution, but it cannot be tested in a PR because those type of workflows only run if they are defined on the default branch.

@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review April 18, 2024 21:41
@make-github-pseudonymous-again
Copy link
Contributor Author

Merging anyway since we can make the PR checks pass by re-running them. Will probably implement #900 just after.

Merged via the queue into main with commit b52046e Apr 18, 2024
21 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the docker-compose-deploy-1 branch May 14, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
1 participant